]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
Subject: [PATCH] tags.sh: Add missing quotes
authorStephen Boyd <sboyd@codeaurora.org>
Sun, 1 Apr 2012 06:41:07 +0000 (23:41 -0700)
committerMichal Marek <mmarek@suse.cz>
Mon, 2 Apr 2012 09:28:17 +0000 (11:28 +0200)
When $remove_structs is empty a test for empty string will turn
into test -n with no arguments meaning true. Add quotes so an
empty string is tested and so that make cscope works again.

Reported-and-tested-by: Jike Song <albcamus@gmail.com>
Reported-by: Prarit Bhargava <prarit@redhat.com>
Acked-by: Yang Bai <hamo.by@gmail.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Michal Marek <mmarek@suse.cz>
scripts/tags.sh

index 0d6004e20658e27b519874ac01c2499572906175..cf7b12fee573174c8aaf00ee75aa9d21c056d61d 100755 (executable)
@@ -254,6 +254,6 @@ case "$1" in
 esac
 
 # Remove structure forward declarations.
-if [ -n $remove_structs ]; then
+if [ -n "$remove_structs" ]; then
     LANG=C sed -i -e '/^\([a-zA-Z_][a-zA-Z0-9_]*\)\t.*\t\/\^struct \1;.*\$\/;"\tx$/d' $1
 fi