]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
net/net_namespace: Check the return value of register_pernet_subsys()
authorAditya Pakki <pakki001@umn.edu>
Mon, 24 Dec 2018 01:42:38 +0000 (19:42 -0600)
committerDavid S. Miller <davem@davemloft.net>
Mon, 24 Dec 2018 22:43:27 +0000 (14:43 -0800)
In net_ns_init(), register_pernet_subsys() could fail while registering
network namespace subsystems. The fix checks the return value and
sends a panic() on failure.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Reviewed-by: Kirill Tkhai <ktkhai@virtuozzo.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/net_namespace.c

index fefe72774aeb3a78d2bec6894cd9494741a78ee4..af8849a7a9c3db5beab42f5f91e0bc98441eb4a0 100644 (file)
@@ -917,7 +917,8 @@ static int __init net_ns_init(void)
        init_net_initialized = true;
        up_write(&pernet_ops_rwsem);
 
-       register_pernet_subsys(&net_ns_ops);
+       if (register_pernet_subsys(&net_ns_ops))
+               panic("Could not register network namespace subsystems");
 
        rtnl_register(PF_UNSPEC, RTM_NEWNSID, rtnl_net_newid, NULL,
                      RTNL_FLAG_DOIT_UNLOCKED);