pstore: Improve and update some comments and status output

This improves and updates some comments:
 - dump handler comment out of sync from calling convention
 - fix kern-doc typo

and improves status output:
 - reminder that only kernel crash dumps are compressed
 - do not be silent about ECC infrastructure failures

Signed-off-by: Kees Cook <keescook@chromium.org>

diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
index a75756c48e10b8624143474d145debf43c51349d..32340e7dd6a50599b2b166aa2ad55411b55c3470 100644 (file)
--- a/fs/pstore/platform.c
+++ b/fs/pstore/platform.c
@@ -304,7 +304,7 @@ static void allocate_buf_for_compression(void)
        big_oops_buf_sz = size;
        big_oops_buf = buf;
 
-       pr_info("Using compression: %s\n", zbackend->name);
+       pr_info("Using crash dump compression: %s\n", zbackend->name);
 }
 
 static void free_buf_for_compression(void)
@@ -354,9 +354,8 @@ void pstore_record_init(struct pstore_record *record,
 }
 
 /*
- * callback from kmsg_dump. (s2,l2) has the most recently
- * written bytes, older bytes are in (s1,l1). Save as much
- * as we can from the end of the buffer.
+ * callback from kmsg_dump. Save as much as we can (up to kmsg_bytes) from the
+ * end of the buffer.
  */
 static void pstore_dump(struct kmsg_dumper *dumper,
                        enum kmsg_dump_reason reason)

diff --git a/fs/pstore/ram_core.c b/fs/pstore/ram_core.c
index 3e9e3ba4fb07aa9873e750396d7dcd14ddad7a2e..e6375439c5aca25d172c3105ecc18d053c088429 100644 (file)
--- a/fs/pstore/ram_core.c
+++ b/fs/pstore/ram_core.c
@@ -503,8 +503,10 @@ static int persistent_ram_post_init(struct persistent_ram_zone *prz, u32 sig,
        bool zap = !!(prz->flags & PRZ_FLAG_ZAP_OLD);
 
        ret = persistent_ram_init_ecc(prz, ecc_info);
-       if (ret)
+       if (ret) {
+               pr_warn("ECC failed %s\n", prz->label);
                return ret;
+       }
 
        sig ^= PERSISTENT_RAM_SIG;
 

diff --git a/include/linux/pstore.h b/include/linux/pstore.h
index 30fcec375a3af2d8b0ee305b7c540a15080847d2..81669aa800274c1ac1630665b6369e2066a790cd 100644 (file)
--- a/include/linux/pstore.h
+++ b/include/linux/pstore.h
@@ -85,7 +85,7 @@ struct pstore_record {
 /**
  * struct pstore_info - backend pstore driver structure
  *
- * @owner:     module which is repsonsible for this backend driver
+ * @owner:     module which is responsible for this backend driver
  * @name:      name of the backend driver
  *
  * @buf_lock:  spinlock to serialize access to @buf