]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commitdiff
mmc: sdhci: fix data timeout (part 1)
authorRussell King <rmk+kernel@arm.linux.org.uk>
Tue, 26 Jan 2016 13:40:58 +0000 (13:40 +0000)
committerTim Gardner <tim.gardner@canonical.com>
Thu, 21 Apr 2016 12:53:40 +0000 (06:53 -0600)
BugLink: http://bugs.launchpad.net/bugs/1572722
commit fafcfda9e78cae8796d1799f14e6457790797555 upstream.

The data timeout gives the minimum amount of time that should be
waited before timing out if no data is received from the card.
Simply dividing the nanosecond part by 1000 does not give this
required guarantee, since such a division rounds down.  Use
DIV_ROUND_UP() to give the desired timeout.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Tested-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
drivers/mmc/host/sdhci.c

index 0f77eab0c47a7724adf3c4bb4491806383486af2..f5053ef55f3c440fdb33f90a33f0a112ec789473 100644 (file)
@@ -666,7 +666,7 @@ static u8 sdhci_calc_timeout(struct sdhci_host *host, struct mmc_command *cmd)
        if (!data)
                target_timeout = cmd->busy_timeout * 1000;
        else {
-               target_timeout = data->timeout_ns / 1000;
+               target_timeout = DIV_ROUND_UP(data->timeout_ns, 1000);
                if (host->clock)
                        target_timeout += data->timeout_clks / host->clock;
        }