]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
sctp: pass a kernel pointer to sctp_setsockopt_disable_fragments
authorChristoph Hellwig <hch@lst.de>
Sun, 19 Jul 2020 07:21:41 +0000 (09:21 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 20 Jul 2020 01:26:41 +0000 (18:26 -0700)
Use the kernel pointer that sctp_setsockopt has available instead of
directly handling the user pointer.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/socket.c

index 44cf2848146a91779b165664f2ade745ed37b6dd..b259ea94aeddef1a86ed7ce1147dfe8cf2598a83 100644 (file)
@@ -2184,20 +2184,12 @@ out:
  * exceeds the current PMTU size, the message will NOT be sent and
  * instead a error will be indicated to the user.
  */
-static int sctp_setsockopt_disable_fragments(struct sock *sk,
-                                            char __user *optval,
+static int sctp_setsockopt_disable_fragments(struct sock *sk, int *val,
                                             unsigned int optlen)
 {
-       int val;
-
        if (optlen < sizeof(int))
                return -EINVAL;
-
-       if (get_user(val, (int __user *)optval))
-               return -EFAULT;
-
-       sctp_sk(sk)->disable_fragments = (val == 0) ? 0 : 1;
-
+       sctp_sk(sk)->disable_fragments = (*val == 0) ? 0 : 1;
        return 0;
 }
 
@@ -4701,7 +4693,7 @@ static int sctp_setsockopt(struct sock *sk, int level, int optname,
                break;
 
        case SCTP_DISABLE_FRAGMENTS:
-               retval = sctp_setsockopt_disable_fragments(sk, optval, optlen);
+               retval = sctp_setsockopt_disable_fragments(sk, kopt, optlen);
                break;
 
        case SCTP_EVENTS: