]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
usb: musb: omap2430: Add support for idling phy when musb is idle
authorTony Lindgren <tony@atomide.com>
Tue, 30 Apr 2019 14:59:36 +0000 (09:59 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 30 Apr 2019 15:55:08 +0000 (17:55 +0200)
I noticed that musb is blocking core retention for omap4 unlike for
omap3. This is because for omap3 we have phy-twl4030-usb implement
it's own PM runtime to handle errata "VUSB3V1 VBUS overvoltage
debouncer not working when the PHY is powered down". That is done
in order to keep the USB PHY powered when phy-twl4030-usb is loaded.

For the other USB PHYs, we need to enable and disable the PHY based on
musb PM runtime. With the session bit based PM runtime for musb core,
we can now idle the USB PHY always when musb is idle.

Note that adding these calls will not affect the twl4030 driver
as it's phy functions will just query the PHY state without powering
the PHY on or off.

Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Bin Liu <b-liu@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/musb/omap2430.c

index b1dd81fb5f55e3e9fbe249bb7cc058cc5e5a2e85..a3d2fef6774682fdab89883907060fcbc81c93d0 100644 (file)
@@ -531,6 +531,9 @@ static int omap2430_runtime_suspend(struct device *dev)
 
        omap2430_low_level_exit(musb);
 
+       phy_power_off(musb->phy);
+       phy_exit(musb->phy);
+
        return 0;
 }
 
@@ -542,6 +545,9 @@ static int omap2430_runtime_resume(struct device *dev)
        if (!musb)
                return 0;
 
+       phy_init(musb->phy);
+       phy_power_on(musb->phy);
+
        omap2430_low_level_init(musb);
        musb_writel(musb->mregs, OTG_INTERFSEL,
                    musb->context.otg_interfsel);