]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
fs/io_uring Don't use the return value from import_iovec().
authorDavid Laight <David.Laight@ACULAB.COM>
Sat, 7 Nov 2020 13:16:25 +0000 (13:16 +0000)
committerJens Axboe <axboe@kernel.dk>
Wed, 9 Dec 2020 19:04:00 +0000 (12:04 -0700)
This is the only code that relies on import_iovec() returning
iter.count on success.
This allows a better interface to import_iovec().

Signed-off-by: David Laight <david.laight@aculab.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Reviewed-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c

index 775a83ebc8ab67db6895f06a69645bd37696c763..c1ac352e3e156da67a70a39719962cef5beedceb 100644 (file)
@@ -3179,7 +3179,7 @@ static ssize_t __io_import_iovec(int rw, struct io_kiocb *req,
 
                ret = import_single_range(rw, buf, sqe_len, *iovec, iter);
                *iovec = NULL;
-               return ret < 0 ? ret : sqe_len;
+               return ret;
        }
 
        if (req->flags & REQ_F_BUFFER_SELECT) {
@@ -3205,7 +3205,7 @@ static ssize_t io_import_iovec(int rw, struct io_kiocb *req,
        if (!iorw)
                return __io_import_iovec(rw, req, iovec, iter, needs_lock);
        *iovec = NULL;
-       return iov_iter_count(&iorw->iter);
+       return 0;
 }
 
 static inline loff_t *io_kiocb_ppos(struct kiocb *kiocb)
@@ -3474,7 +3474,7 @@ static int io_read(struct io_kiocb *req, bool force_nonblock,
        if (ret < 0)
                return ret;
        iov_count = iov_iter_count(iter);
-       io_size = ret;
+       io_size = iov_count;
        req->result = io_size;
        ret = 0;
 
@@ -3602,7 +3602,7 @@ static int io_write(struct io_kiocb *req, bool force_nonblock,
        if (ret < 0)
                return ret;
        iov_count = iov_iter_count(iter);
-       io_size = ret;
+       io_size = iov_count;
        req->result = io_size;
 
        /* Ensure we clear previously set non-block flag */