]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
tile: fix missing unlock on error in tile_net_open()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Mon, 5 Aug 2013 04:42:00 +0000 (12:42 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 5 Aug 2013 18:09:42 +0000 (11:09 -0700)
Add the missing unlock before return from function tile_net_open()
in the error handling case.

Introduced by commit f3286a3af89d6db7a488f3e8f02b98d67d50f00c.
(tile: support multiple mPIPE shims in tilegx network driver)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Chris Metcalf <cmetcalf@tilera.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/tile/tilegx.c

index 907b5772fd552688af2dba806dee70a8a243ff30..5d2a719fc68824c3b77ee5519406f4f9df31d42f 100644 (file)
@@ -1510,8 +1510,10 @@ static int tile_net_open(struct net_device *dev)
 
        /* Get the instance info. */
        rc = gxio_mpipe_link_instance(dev->name);
-       if (rc < 0 || rc >= NR_MPIPE_MAX)
+       if (rc < 0 || rc >= NR_MPIPE_MAX) {
+               mutex_unlock(&tile_net_devs_for_channel_mutex);
                return -EIO;
+       }
 
        priv->instance = rc;
        instance = rc;