]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
brcmfmac: do not convert linux error to firmware error string
authorArend Van Spriel <arend.vanspriel@broadcom.com>
Thu, 22 Mar 2018 20:28:20 +0000 (21:28 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 27 Mar 2018 09:04:20 +0000 (12:04 +0300)
In case of a linux error brcmf_fil_cmd_data() blurts an error message
in which the error code is translated to an error string. However, it
maps it to a firmware error string which should not happen. Simply
print only the numeric error code and be done with it.

Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
Reviewed-by: Franky Lin <franky.lin@broadcom.com>
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.c

index fc5751116d99bf89f46769eb57bee290f6ae35c8..802d7cb73b80f083c764eaaf75a5ec011eb3a05c 100644 (file)
@@ -124,8 +124,7 @@ brcmf_fil_cmd_data(struct brcmf_if *ifp, u32 cmd, void *data, u32 len, bool set)
                                             data, len, &fwerr);
 
        if (err) {
-               brcmf_dbg(FIL, "Failed: %s (%d)\n",
-                         brcmf_fil_get_errstr((u32)(-err)), err);
+               brcmf_dbg(FIL, "Failed: error=%d\n", err);
        } else if (fwerr < 0) {
                brcmf_dbg(FIL, "Firmware error: %s (%d)\n",
                          brcmf_fil_get_errstr((u32)(-fwerr)), fwerr);