]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
net: ethernet: eth.c: removed checkpatch warnings and errors
authorAvinash Kumar <avi.kp.137@gmail.com>
Thu, 19 Sep 2013 16:06:50 +0000 (21:36 +0530)
committerDavid S. Miller <davem@davemloft.net>
Fri, 20 Sep 2013 18:41:02 +0000 (14:41 -0400)
removed these checkpatch.pl warnings:
net/ethernet/eth.c:61: WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
net/ethernet/eth.c:136: WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(...  to printk(KERN_DEBUG ...
net/ethernet/eth.c:181: ERROR: space prohibited before that close parenthesis ')'

Signed-off-by: Avinash Kumar <avi.kp.137@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ethernet/eth.c

index be1f64d35358fbfbf61d84683c52e4d6fb423f34..9bd3c31c30e5f6f0cf6c9195586cd26787b539bd 100644 (file)
@@ -58,7 +58,7 @@
 #include <net/ipv6.h>
 #include <net/ip.h>
 #include <net/dsa.h>
-#include <asm/uaccess.h>
+#include <linux/uaccess.h>
 
 __setup("ether=", netdev_boot_setup);
 
@@ -133,7 +133,7 @@ int eth_rebuild_header(struct sk_buff *skb)
                return arp_find(eth->h_dest, skb);
 #endif
        default:
-               printk(KERN_DEBUG
+               netdev_dbg(dev,
                       "%s: unable to resolve type %X addresses.\n",
                       dev->name, ntohs(eth->h_proto));
 
@@ -178,7 +178,7 @@ __be16 eth_type_trans(struct sk_buff *skb, struct net_device *dev)
         *      seems to set IFF_PROMISC.
         */
 
-       else if (1 /*dev->flags&IFF_PROMISC */ ) {
+       else if (1 /*dev->flags&IFF_PROMISC */) {
                if (unlikely(!ether_addr_equal_64bits(eth->h_dest,
                                                      dev->dev_addr)))
                        skb->pkt_type = PACKET_OTHERHOST;