]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
nfs: add error check in nfs_idmap_prepare_message()
authorChengguang Xu <cgxu519@gmx.com>
Thu, 28 Jun 2018 03:09:45 +0000 (11:09 +0800)
committerAnna Schumaker <Anna.Schumaker@Netapp.com>
Mon, 30 Jul 2018 17:19:40 +0000 (13:19 -0400)
Even though the caller of nfs_idmap_prepare_message() checks return
code in their side but it's better to add an error check for match_int()
so that we can avoid unnecessary operations when bad int arg is
detected.

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
fs/nfs/nfs4idmap.c

index b6f9d84ba19b1a1002cbc22760ab4d84bd396006..cf72169d6c642e706d6cba16bd565a9a2047d29a 100644 (file)
@@ -516,6 +516,8 @@ static int nfs_idmap_prepare_message(char *desc, struct idmap *idmap,
        case Opt_find_group:
                im->im_conv = IDMAP_CONV_IDTONAME;
                ret = match_int(&substr, &im->im_id);
+               if (ret)
+                       goto out;
                break;
 
        default: