]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
media: staging: media: imx: fix inconsistent IS_ERR and PTR_ERR
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Tue, 17 Oct 2017 17:19:07 +0000 (13:19 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 8 Dec 2017 16:11:52 +0000 (11:11 -0500)
Fix inconsistent IS_ERR and PTR_ERR in csi_link_validate.
The proper pointer to be passed as argument is sensor.

This issue was detected with the help of Coccinelle.

Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/staging/media/imx/imx-media-csi.c

index bb1d6dafca83473eea250ff24be74b1505c9b533..ebb4ca530de2efe48adebf8ed2d27b63db3ca608 100644 (file)
@@ -989,7 +989,7 @@ static int csi_link_validate(struct v4l2_subdev *sd,
        sensor = __imx_media_find_sensor(priv->md, &priv->sd.entity);
        if (IS_ERR(sensor)) {
                v4l2_err(&priv->sd, "no sensor attached\n");
-               return PTR_ERR(priv->sensor);
+               return PTR_ERR(sensor);
        }
 
        mutex_lock(&priv->lock);