]> git.proxmox.com Git - mirror_qemu.git/commitdiff
translate: early exit in tb_flush if there is no tcg
authorChristian Borntraeger <borntraeger@de.ibm.com>
Thu, 25 Aug 2016 18:11:26 +0000 (20:11 +0200)
committerPeter Maydell <peter.maydell@linaro.org>
Tue, 30 Aug 2016 12:30:55 +0000 (13:30 +0100)
tb_flush does all kind of things, which are very tcg specific. As it
is called from some places even for KVM (e.g. gdb server) it is better
to detect these cases and do an early exit.
This also fixes a crash in the gdb server that was triggered by
commit 909eaac9bbc2 ("tb hash: track translated blocks with qht").

Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Reported-by: Richard Henderson <rth@twiddle.net>
Reported-by: Brent Baccala <cosine@freesoft.org>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Message-id: 1472148686-39841-1-git-send-email-borntraeger@de.ibm.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
translate-all.c

index efeba298b9eb12bce524892ceefb056247e9e36a..0dd6466e071fdaec586f69c4032d2468284958a8 100644 (file)
@@ -834,6 +834,9 @@ static void page_flush_tb(void)
 /* XXX: tb_flush is currently not thread safe */
 void tb_flush(CPUState *cpu)
 {
+    if (!tcg_enabled()) {
+        return;
+    }
 #if defined(DEBUG_FLUSH)
     printf("qemu: flush code_size=%ld nb_tbs=%d avg_tb_size=%ld\n",
            (unsigned long)(tcg_ctx.code_gen_ptr - tcg_ctx.code_gen_buffer),