]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commitdiff
greybus: arche-platform: svc_reset_gpio can't be invalid in arche_platform_cleanup()
authorViresh Kumar <viresh.kumar@linaro.org>
Mon, 11 Jan 2016 05:59:06 +0000 (11:29 +0530)
committerGreg Kroah-Hartman <gregkh@google.com>
Mon, 11 Jan 2016 23:58:01 +0000 (15:58 -0800)
svc_reset_gpio is guaranteed to be valid in arche_platform_cleanup. Drop
the useless check.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
drivers/staging/greybus/arche-platform.c

index 67bbd71ec3d1d44604e20947f6d549f3c46ebc87..93ecd8c8bed70040477c255b6147ff67fe0a1fcf 100644 (file)
@@ -61,9 +61,8 @@ static void unexport_gpios(struct arche_platform_drvdata *arche_pdata)
 static void arche_platform_cleanup(struct arche_platform_drvdata *arche_pdata)
 {
        /* As part of exit, put APB back in reset state */
-       if (gpio_is_valid(arche_pdata->svc_reset_gpio))
-               svc_reset_onoff(arche_pdata->svc_reset_gpio,
-                               arche_pdata->is_reset_act_hi);
+       svc_reset_onoff(arche_pdata->svc_reset_gpio,
+                       arche_pdata->is_reset_act_hi);
 }
 
 static int arche_platform_probe(struct platform_device *pdev)