]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
ALSA: usb-audio: fix overeager device match for MacroSilicon MS2109
authorHector Martin <marcan@marcan.st>
Mon, 10 Aug 2020 04:53:19 +0000 (13:53 +0900)
committerTakashi Iwai <tiwai@suse.de>
Mon, 10 Aug 2020 06:41:48 +0000 (08:41 +0200)
Matching by device matches all interfaces, which breaks the video/HID
portions of the device depending on module load order.

Fixes: e337bf19f6af ("ALSA: usb-audio: add quirk for MacroSilicon MS2109")
Cc: stable@vger.kernel.org
Signed-off-by: Hector Martin <marcan@marcan.st>
Link: https://lore.kernel.org/r/20200810045319.128745-1-marcan@marcan.st
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/quirks-table.h

index adb3b62afed43eb08ae587746fb5be52be85c3c0..9c3c03dc96d3e5eacaa43d179192ed199cc93c72 100644 (file)
@@ -3662,7 +3662,13 @@ ALC1220_VB_DESKTOP(0x26ce, 0x0a01), /* Asrock TRX40 Creator */
  * with.
  */
 {
-       USB_DEVICE(0x534d, 0x2109),
+       .match_flags = USB_DEVICE_ID_MATCH_DEVICE |
+                      USB_DEVICE_ID_MATCH_INT_CLASS |
+                      USB_DEVICE_ID_MATCH_INT_SUBCLASS,
+       .idVendor = 0x534d,
+       .idProduct = 0x2109,
+       .bInterfaceClass = USB_CLASS_AUDIO,
+       .bInterfaceSubClass = USB_SUBCLASS_AUDIOCONTROL,
        .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) {
                .vendor_name = "MacroSilicon",
                .product_name = "MS2109",