EDAC, thunderx: Fix memory leak in thunderx_l2c_threaded_isr()

BugLink: https://bugs.launchpad.net/bugs/1854975
[ Upstream commit d8c27ba86a2fd806d3957e5a9b30e66dfca2a61d ]

Fix memory leak in L2c threaded interrupt handler.

 [ bp: Rewrite commit message. ]

Fixes: 41003396f932 ("EDAC, thunderx: Add Cavium ThunderX EDAC driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
CC: David Daney <david.daney@cavium.com>
CC: Jan Glauber <jglauber@cavium.com>
CC: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: Sergey Temerkhanov <s.temerkhanov@gmail.com>
CC: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/20181013102843.GG16086@mwanda
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

diff --git a/drivers/edac/thunderx_edac.c b/drivers/edac/thunderx_edac.c
index 4803c6468bab4d18eafe65514344c2de02dd909c..17e54f12ddb6ad92493af14e5a02c52392c6fbc7 100644 (file)
--- a/drivers/edac/thunderx_edac.c
+++ b/drivers/edac/thunderx_edac.c
@@ -1880,7 +1880,7 @@ static irqreturn_t thunderx_l2c_threaded_isr(int irq, void *irq_id)
        default:
                dev_err(&l2c->pdev->dev, "Unsupported device: %04x\n",
                        l2c->pdev->device);
-               return IRQ_NONE;
+               goto err_free;
        }
 
        while (CIRC_CNT(l2c->ring_head, l2c->ring_tail,
@@ -1902,7 +1902,7 @@ static irqreturn_t thunderx_l2c_threaded_isr(int irq, void *irq_id)
                l2c->ring_tail++;
        }
 
-       return IRQ_HANDLED;
+       ret = IRQ_HANDLED;
 
 err_free:
        kfree(other);