misc: xilinx_sdfec: Use memdup_user() as a cleanup

Fix coccicheck warning which recommends to use memdup_user().

This patch fixes the following coccicheck warnings:

drivers/misc/xilinx_sdfec.c:652:8-15: WARNING opportunity for memdup_user

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Link: https://lore.kernel.org/r/1587524330-119776-1-git-send-email-zou_wei@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c
index 71bbaa56bdb5b40f9909dd6ca842934326409b67..7a7589417e873aa853d014be46480cbaee8f8de5 100644 (file)
--- a/drivers/misc/xilinx_sdfec.c
+++ b/drivers/misc/xilinx_sdfec.c
@@ -649,14 +649,9 @@ static int xsdfec_add_ldpc(struct xsdfec_dev *xsdfec, void __user *arg)
        struct xsdfec_ldpc_params *ldpc;
        int ret, n;
 
-       ldpc = kzalloc(sizeof(*ldpc), GFP_KERNEL);
-       if (!ldpc)
-               return -ENOMEM;
-
-       if (copy_from_user(ldpc, arg, sizeof(*ldpc))) {
-               ret = -EFAULT;
-               goto err_out;
-       }
+       ldpc = memdup_user(arg, sizeof(*ldpc));
+       if (IS_ERR(ldpc))
+               return PTR_ERR(ldpc);
 
        if (xsdfec->config.code == XSDFEC_TURBO_CODE) {
                ret = -EIO;