]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
media: s5k6a3: Fix runtime PM imbalance on error
authorDinghao Liu <dinghao.liu@zju.edu.cn>
Thu, 21 May 2020 11:07:47 +0000 (13:07 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 23 Jun 2020 11:18:25 +0000 (13:18 +0200)
pm_runtime_get() increments the runtime PM usage counter even
when it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/i2c/s5k6a3.c

index bc6cc5a558db0d463054220da36ed942e47a6f37..f26c168ef942e33f10eaed46037659296c24e931 100644 (file)
@@ -197,7 +197,7 @@ static int __s5k6a3_power_on(struct s5k6a3 *sensor)
 
        ret = pm_runtime_get(sensor->dev);
        if (ret < 0)
-               return ret;
+               goto error_rpm_put;
 
        ret = regulator_enable(sensor->supplies[i].consumer);
        if (ret < 0)