]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
net: phy: micrel: Pass .probe for KS8737
authorFabio Estevam <festevam@denx.de>
Wed, 4 May 2022 14:31:04 +0000 (11:31 -0300)
committerJakub Kicinski <kuba@kernel.org>
Fri, 6 May 2022 00:02:02 +0000 (17:02 -0700)
Since commit f1131b9c23fb ("net: phy: micrel: use
kszphy_suspend()/kszphy_resume for irq aware devices") the kszphy_suspend/
resume hooks are used.

These functions require the probe function to be called so that
priv can be allocated.

Otherwise, a NULL pointer dereference happens inside
kszphy_config_reset().

Cc: stable@vger.kernel.org
Fixes: f1131b9c23fb ("net: phy: micrel: use kszphy_suspend()/kszphy_resume for irq aware devices")
Reported-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20220504143104.1286960-2-festevam@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/micrel.c

index 7c243cedde9f8b27e4c0035fed6a8a6f170045f1..9d7dafed393189d709b276fab732610cb882383d 100644 (file)
@@ -2657,6 +2657,7 @@ static struct phy_driver ksphy_driver[] = {
        .name           = "Micrel KS8737",
        /* PHY_BASIC_FEATURES */
        .driver_data    = &ks8737_type,
+       .probe          = kszphy_probe,
        .config_init    = kszphy_config_init,
        .config_intr    = kszphy_config_intr,
        .handle_interrupt = kszphy_handle_interrupt,