]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
scsi: libcxgbi: return error if interface is not up
authorVarun Prakash <varun@chelsio.com>
Fri, 9 Dec 2016 09:10:07 +0000 (14:40 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 14 Dec 2016 20:11:53 +0000 (15:11 -0500)
Do not post hw active open cmd if IFF_UP is not set or link is down on
the interface, return -ENETDOWN in this case.

Signed-off-by: Varun Prakash <varun@chelsio.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/cxgbi/libcxgbi.c

index 9f4fde9b12e369d7d317be721cfe9ab270ddfdd2..9167bcd9fffe9b3a5fea9005671239a96551aace 100644 (file)
@@ -642,6 +642,12 @@ static struct cxgbi_sock *cxgbi_check_route(struct sockaddr *dst_addr)
                        n->dev->name, ndev->name, mtu);
        }
 
+       if (!(ndev->flags & IFF_UP) || !netif_carrier_ok(ndev)) {
+               pr_info("%s interface not up.\n", ndev->name);
+               err = -ENETDOWN;
+               goto rel_neigh;
+       }
+
        cdev = cxgbi_device_find_by_netdev(ndev, &port);
        if (!cdev) {
                pr_info("dst %pI4, %s, NOT cxgbi device.\n",
@@ -736,6 +742,12 @@ static struct cxgbi_sock *cxgbi_check_route6(struct sockaddr *dst_addr)
        }
        ndev = n->dev;
 
+       if (!(ndev->flags & IFF_UP) || !netif_carrier_ok(ndev)) {
+               pr_info("%s interface not up.\n", ndev->name);
+               err = -ENETDOWN;
+               goto rel_rt;
+       }
+
        if (ipv6_addr_is_multicast(&daddr6->sin6_addr)) {
                pr_info("multi-cast route %pI6 port %u, dev %s.\n",
                        daddr6->sin6_addr.s6_addr,