]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commitdiff
IDE: Deletion of an unnecessary check before the function call "module_put"
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 21 Nov 2014 19:22:32 +0000 (20:22 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 12 Dec 2014 20:26:31 +0000 (15:26 -0500)
The module_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/ide/ide.c

index 2ce6268a27348c9bfab9910da2ea3f9a364b1a44..e29b02ca9e915d31735d35d9cf46438d38182e22 100644 (file)
@@ -101,8 +101,7 @@ void ide_device_put(ide_drive_t *drive)
        struct device *host_dev = drive->hwif->host->dev[0];
        struct module *module = host_dev ? host_dev->driver->owner : NULL;
 
-       if (module)
-               module_put(module);
+       module_put(module);
 #endif
        put_device(&drive->gendev);
 }