]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
net: stmmac: Fix missing spin_lock_init in visconti_eth_dwmac_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Tue, 23 Feb 2021 10:48:03 +0000 (10:48 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 25 Feb 2021 00:11:28 +0000 (16:11 -0800)
The driver allocates the spinlock but not initialize it.
Use spin_lock_init() on it to initialize it correctly.

Fixes: b38dd98ff8d0 ("net: stmmac: Add Toshiba Visconti SoCs glue driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Link: https://lore.kernel.org/r/20210223104803.4047281-1-weiyongjun1@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c

index b7a0c57dfbfb43ff17095fbb96d31ddf67968121..d23be45a64e5d5a574fc508f32531c0054330736 100644 (file)
@@ -218,6 +218,7 @@ static int visconti_eth_dwmac_probe(struct platform_device *pdev)
                goto remove_config;
        }
 
+       spin_lock_init(&dwmac->lock);
        dwmac->reg = stmmac_res.addr;
        plat_dat->bsp_priv = dwmac;
        plat_dat->fix_mac_speed = visconti_eth_fix_mac_speed;