]> git.proxmox.com Git - mirror_lxc.git/commitdiff
criu: Remove unnecessary return after _exit()
authorRikard Falkeborn <rikard.falkeborn@gmail.com>
Sat, 11 May 2019 23:39:51 +0000 (01:39 +0200)
committerRikard Falkeborn <rikard.falkeborn@gmail.com>
Sat, 11 May 2019 23:55:34 +0000 (01:55 +0200)
Since _exit() will terminate, the return statement is dead code. Also,
returning -1 from a function with bool as return type is confusing.

Detected with cppcheck.

Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
src/lxc/criu.c

index 1b74cf8137417b428a351daf75162d8ff62d999b..86f6f1836710b59ec9f7673f42ad30e291e8c52d 100644 (file)
@@ -1273,7 +1273,6 @@ static bool do_dump(struct lxc_container *c, char *mode, struct migrate_opts *op
                if (!cgroup_ops) {
                        ERROR("failed to cgroup_init()");
                        _exit(EXIT_FAILURE);
-                       return -1;
                }
 
                os.pipefd = criuout[1];