]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
virtio_ring: mark ring unused on error
authorMichael S. Tsirkin <mst@redhat.com>
Thu, 6 Jan 2022 12:57:46 +0000 (07:57 -0500)
committerMichael S. Tsirkin <mst@redhat.com>
Fri, 14 Jan 2022 23:50:53 +0000 (18:50 -0500)
A recently added error path does not mark ring unused when exiting on
OOM, which will lead to BUG on the next entry in debug builds.

TODO: refactor code so we have START_USE and END_USE in the same function.

Fixes: fc6d70f40b3d ("virtio_ring: check desc == NULL when using indirect with packed")
Cc: "Xuan Zhuo" <xuanzhuo@linux.alibaba.com>
Cc: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/virtio/virtio_ring.c

index 028b05d4454604d5aee636895f8fcfee77a2b46a..962f1477b1fabd9fbed81696956cc7e978ced582 100644 (file)
@@ -1197,8 +1197,10 @@ static inline int virtqueue_add_packed(struct virtqueue *_vq,
        if (virtqueue_use_indirect(_vq, total_sg)) {
                err = virtqueue_add_indirect_packed(vq, sgs, total_sg, out_sgs,
                                                    in_sgs, data, gfp);
-               if (err != -ENOMEM)
+               if (err != -ENOMEM) {
+                       END_USE(vq);
                        return err;
+               }
 
                /* fall back on direct */
        }