]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
ARM: dma-mapping: Set proper DMA ops in arm_iommu_detach_device()
authorThierry Reding <treding@nvidia.com>
Wed, 30 May 2018 14:06:24 +0000 (16:06 +0200)
committerBen Skeggs <bskeggs@redhat.com>
Mon, 16 Jul 2018 08:06:36 +0000 (18:06 +1000)
Instead of setting the DMA ops pointer to NULL, set the correct,
non-IOMMU ops depending on the device's coherency setting.

Signed-off-by: Thierry Reding <treding@nvidia.com>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
Acked-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
arch/arm/mm/dma-mapping.c

index be0fa7e39c2621ea4a9a83744e513f4d62d246c4..ba0e786c952e70a1989ccb93043bb08e4d721d28 100644 (file)
@@ -1151,6 +1151,11 @@ int arm_dma_supported(struct device *dev, u64 mask)
        return __dma_supported(dev, mask, false);
 }
 
+static const struct dma_map_ops *arm_get_dma_map_ops(bool coherent)
+{
+       return coherent ? &arm_coherent_dma_ops : &arm_dma_ops;
+}
+
 #ifdef CONFIG_ARM_DMA_USE_IOMMU
 
 static int __dma_info_to_prot(enum dma_data_direction dir, unsigned long attrs)
@@ -2296,7 +2301,7 @@ void arm_iommu_detach_device(struct device *dev)
        iommu_detach_device(mapping->domain, dev);
        kref_put(&mapping->kref, release_iommu_mapping);
        to_dma_iommu_mapping(dev) = NULL;
-       set_dma_ops(dev, NULL);
+       set_dma_ops(dev, arm_get_dma_map_ops(dev->archdata.dma_coherent));
 
        pr_debug("Detached IOMMU controller from %s device.\n", dev_name(dev));
 }
@@ -2357,11 +2362,6 @@ static void arm_teardown_iommu_dma_ops(struct device *dev) { }
 
 #endif /* CONFIG_ARM_DMA_USE_IOMMU */
 
-static const struct dma_map_ops *arm_get_dma_map_ops(bool coherent)
-{
-       return coherent ? &arm_coherent_dma_ops : &arm_dma_ops;
-}
-
 void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size,
                        const struct iommu_ops *iommu, bool coherent)
 {