devlink: catch missing strings in dl_args_required

Currently if dl_args_required doesn't contain a string
for a given option the fact that the option is missing
is silently ignored.

Add a catch-all case and print a generic error.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David Ahern <dsahern@gmail.com>

diff --git a/devlink/devlink.c b/devlink/devlink.c
index 682f832a064caba72dff7ce895ba26aefd7884cc..e05a2336787a4a28fcf00db0bfb94bbdac5e441e 100644 (file)
--- a/devlink/devlink.c
+++ b/devlink/devlink.c
@@ -1157,6 +1157,10 @@ static int dl_args_finding_required_validate(uint64_t o_required,
                        return -EINVAL;
                }
        }
+       if (o_required & ~o_found) {
+               pr_err("BUG: unknown argument required but not found\n");
+               return -EINVAL;
+       }
        return 0;
 }