]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
leds: bcm6328, bcm6358: use devres LED registering function
authorMarek Behún <marek.behun@nic.cz>
Thu, 17 Sep 2020 22:32:58 +0000 (00:32 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Thu, 10 Dec 2020 11:03:04 +0000 (12:03 +0100)
BugLink: https://bugs.launchpad.net/bugs/1904450
commit ff5c89d44453e7ad99502b04bf798a3fc32c758b upstream.

These two drivers do not provide remove method and use devres for
allocation of other resources, yet they use led_classdev_register
instead of the devres variant, devm_led_classdev_register.

Fix this.

Signed-off-by: Marek Behún <marek.behun@nic.cz>
Cc: Álvaro Fernández Rojas <noltari@gmail.com>
Cc: Kevin Cernekee <cernekee@gmail.com>
Cc: Jaedon Shin <jaedon.shin@gmail.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Cc: stable@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: William Breathitt Gray <william.gray@canonical.com>
drivers/leds/leds-bcm6328.c
drivers/leds/leds-bcm6358.c

index c50d34e2b09839f7a2e456d87b08395a273a5b05..de932755bcb34c6f812b4574d0bfd7edb67590c6 100644 (file)
@@ -332,7 +332,7 @@ static int bcm6328_led(struct device *dev, struct device_node *nc, u32 reg,
        led->cdev.brightness_set = bcm6328_led_set;
        led->cdev.blink_set = bcm6328_blink_set;
 
-       rc = led_classdev_register(dev, &led->cdev);
+       rc = devm_led_classdev_register(dev, &led->cdev);
        if (rc < 0)
                return rc;
 
index aec285fd21c05fd960fe6cbb1f0c0a6fd5830604..dbb8953334d90c5f734728d212d51590d3e2f566 100644 (file)
@@ -137,7 +137,7 @@ static int bcm6358_led(struct device *dev, struct device_node *nc, u32 reg,
 
        led->cdev.brightness_set = bcm6358_led_set;
 
-       rc = led_classdev_register(dev, &led->cdev);
+       rc = devm_led_classdev_register(dev, &led->cdev);
        if (rc < 0)
                return rc;