]> git.proxmox.com Git - mirror_qemu.git/commitdiff
target/arm: Set ISSIs16Bit in make_issinfo
authorRichard Henderson <richard.henderson@linaro.org>
Fri, 17 Jan 2020 14:09:31 +0000 (14:09 +0000)
committerPeter Maydell <peter.maydell@linaro.org>
Fri, 17 Jan 2020 14:27:16 +0000 (14:27 +0000)
During the conversion to decodetree, the setting of
ISSIs16Bit got lost.  This causes the guest os to
incorrectly adjust trapping memory operations.

Cc: qemu-stable@nongnu.org
Fixes: 46beb58efbb8a2a32 ("target/arm: Convert T16, load (literal)")
Reported-by: Jeff Kubascik <jeff.kubascik@dornerworks.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20200117004618.2742-3-richard.henderson@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
target/arm/translate.c

index 0c8624fb42ecd83c0b487965c8b0ae9a7985a83b..2f4aea927f1e8f8b71b447facd3b2e1d8dbb5cfa 100644 (file)
@@ -8556,6 +8556,9 @@ static ISSInfo make_issinfo(DisasContext *s, int rd, bool p, bool w)
     /* ISS not valid if writeback */
     if (p && !w) {
         ret = rd;
+        if (s->base.pc_next - s->pc_curr == 2) {
+            ret |= ISSIs16Bit;
+        }
     } else {
         ret = ISSInvalid;
     }