]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
[media] bdisp: remove needless check
authorFabien Dessenne <fabien.dessenne@st.com>
Wed, 10 Jun 2015 10:19:37 +0000 (07:19 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Wed, 10 Jun 2015 15:29:55 +0000 (12:29 -0300)
As reported by smatch:
drivers/media/platform/sti/bdisp/bdisp-v4l2.c:947 bdisp_s_selection() warn: unsigned 'out.width' is never less than zero.
drivers/media/platform/sti/bdisp/bdisp-v4l2.c:947 bdisp_s_selection() warn: unsigned 'out.height' is never less than zero.
Indeed, width and height are unsigned.

Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/platform/sti/bdisp/bdisp-v4l2.c

index 89d7a2279bc65a9b2b2d6300b747022256c22ea1..9a8405cd5216ddb543fcf7eda9da70750c7515d6 100644 (file)
@@ -944,8 +944,7 @@ static int bdisp_s_selection(struct file *file, void *fh,
        out.width = ALIGN(in->width, frame->fmt->w_align);
        out.height = ALIGN(in->height, frame->fmt->w_align);
 
-       if ((out.width < 0) || (out.height < 0) ||
-           ((out.left + out.width) > frame->width) ||
+       if (((out.left + out.width) > frame->width) ||
            ((out.top + out.height) > frame->height)) {
                dev_err(ctx->bdisp_dev->dev,
                        "Invalid crop: %dx%d@(%d,%d) vs frame: %dx%d\n",