]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
platform/x86: panasonic-laptop: revert "Resolve hotkey double trigger bug"
authorHans de Goede <hdegoede@redhat.com>
Fri, 24 Jun 2022 11:23:37 +0000 (13:23 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 26 Aug 2022 08:54:26 +0000 (10:54 +0200)
BugLink: https://bugs.launchpad.net/bugs/1986728
[ Upstream commit 83a5ddc3dc561c40d948b85553514aaba99123d8 ]

In hindsight blindly throwing away most of the key-press events is not
a good idea. So revert commit ed83c9171829 ("platform/x86:
panasonic-laptop: Resolve hotkey double trigger bug").

Fixes: ed83c9171829 ("platform/x86: panasonic-laptop: Resolve hotkey double trigger bug")
Reported-and-tested-by: Stefan Seyfried <seife+kernel@b1-systems.com>
Reported-and-tested-by: Kenneth Chan <kenneth.t.chan@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20220624112340.10130-5-hdegoede@redhat.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/platform/x86/panasonic-laptop.c

index b89fbbc2fd081fd38c0da180367a6f4ebf53d82e..cd3c23593eee94188a865484a50a74aabffae3da 100644 (file)
@@ -783,12 +783,8 @@ static void acpi_pcc_generate_keyinput(struct pcc_acpi *pcc)
                                        key, 0x80, false);
        }
 
-       /* for the magic values, see panasonic_keymap[] above */
-       if (key == 7 || key == 9 || key == 10) {
-               if (!sparse_keymap_report_event(hotk_input_dev,
-                                               key, updown, false))
-                       pr_err("Unknown hotkey event: 0x%04llx\n", result);
-       }
+       if (!sparse_keymap_report_event(hotk_input_dev, key, updown, false))
+               pr_err("Unknown hotkey event: 0x%04llx\n", result);
 }
 
 static void acpi_pcc_hotkey_notify(struct acpi_device *device, u32 event)