]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commitdiff
powerpc: Update TM user feature bits in scan_features()
authorAnton Blanchard <anton@samba.org>
Fri, 15 Apr 2016 02:08:19 +0000 (12:08 +1000)
committerKamal Mostafa <kamal@canonical.com>
Mon, 16 May 2016 17:25:50 +0000 (10:25 -0700)
BugLink: http://bugs.launchpad.net/bugs/1578798
commit 4705e02498d6d5a7ab98dfee9595cd5e91db2017 upstream.

We need to update the user TM feature bits (PPC_FEATURE2_HTM and
PPC_FEATURE2_HTM) to mirror what we do with the kernel TM feature
bit.

At the moment, if firmware reports TM is not available we turn off
the kernel TM feature bit but leave the userspace ones on. Userspace
thinks it can execute TM instructions and it dies trying.

This (together with a QEMU patch) fixes PR KVM, which doesn't currently
support TM.

Signed-off-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
arch/powerpc/kernel/prom.c

index fe05a909d6837354c3ce4bfbca6e4ee91b9ed5b4..097f413e785b9f64e4109990581dedf901db99b1 100644 (file)
@@ -161,11 +161,12 @@ static struct ibm_pa_feature {
        {0, MMU_FTR_CI_LARGE_PAGE, 0, 0,                1, 2, 0},
        {CPU_FTR_REAL_LE, 0, PPC_FEATURE_TRUE_LE, 0, 5, 0, 0},
        /*
-        * If the kernel doesn't support TM (ie. CONFIG_PPC_TRANSACTIONAL_MEM=n),
-        * we don't want to turn on CPU_FTR_TM here, so we use CPU_FTR_TM_COMP
-        * which is 0 if the kernel doesn't support TM.
+        * If the kernel doesn't support TM (ie CONFIG_PPC_TRANSACTIONAL_MEM=n),
+        * we don't want to turn on TM here, so we use the *_COMP versions
+        * which are 0 if the kernel doesn't support TM.
         */
-       {CPU_FTR_TM_COMP, 0, 0, 0,              22, 0, 0},
+       {CPU_FTR_TM_COMP, 0, 0,
+        PPC_FEATURE2_HTM_COMP|PPC_FEATURE2_HTM_NOSC_COMP, 22, 0, 0},
 };
 
 static void __init scan_features(unsigned long node, const unsigned char *ftrs,