leds: rt8515: Put fwnode in any case during ->probe()

BugLink: https://bugs.launchpad.net/bugs/1946788
[ Upstream commit 8aa41952ef245449df79100e1942b5e6288b098a ]

fwnode_get_next_available_child_node() bumps a reference counting of
a returned variable. We have to balance it whenever we return to
the caller.

Fixes: e1c6edcbea13 ("leds: rt8515: Add Richtek RT8515 LED driver")
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>

diff --git a/drivers/leds/flash/leds-rt8515.c b/drivers/leds/flash/leds-rt8515.c
index 590bfa180d104f07ba619dd2d65426239e8ccac9..44904fdee3cc0e40446dfbeb1efe2042cb5a8842 100644 (file)
--- a/drivers/leds/flash/leds-rt8515.c
+++ b/drivers/leds/flash/leds-rt8515.c
@@ -343,8 +343,9 @@ static int rt8515_probe(struct platform_device *pdev)
 
        ret = devm_led_classdev_flash_register_ext(dev, fled, &init_data);
        if (ret) {
-               dev_err(dev, "can't register LED %s\n", led->name);
+               fwnode_handle_put(child);
                mutex_destroy(&rt->lock);
+               dev_err(dev, "can't register LED %s\n", led->name);
                return ret;
        }
 
@@ -362,6 +363,7 @@ static int rt8515_probe(struct platform_device *pdev)
                 */
        }
 
+       fwnode_handle_put(child);
        return 0;
 }