]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
ipmi: msghandler: Make symbol 'remove_work_wq' static
authorWei Yongjun <weiyongjun1@huawei.com>
Tue, 23 Nov 2021 08:36:18 +0000 (08:36 +0000)
committerPaolo Pisati <paolo.pisati@canonical.com>
Thu, 9 Dec 2021 10:10:56 +0000 (11:10 +0100)
BugLink: https://bugs.launchpad.net/bugs/1953731
commit 5a3ba99b62d8486de0316334e72ac620d4b94fdd upstream.

The sparse tool complains as follows:

drivers/char/ipmi/ipmi_msghandler.c:194:25: warning:
 symbol 'remove_work_wq' was not declared. Should it be static?

This symbol is not used outside of ipmi_msghandler.c, so
marks it static.

Fixes: 1d49eb91e86e ("ipmi: Move remove_work to dedicated workqueue")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Message-Id: <20211123083618.2366808-1-weiyongjun1@huawei.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/char/ipmi/ipmi_msghandler.c

index f3a2f228f648157f6fb40ac08f41ccc69be44c7b..b404cc46cbda7b5a737e2b125d1ecdd0c2f67444 100644 (file)
@@ -191,7 +191,7 @@ struct ipmi_user {
        struct work_struct remove_work;
 };
 
-struct workqueue_struct *remove_work_wq;
+static struct workqueue_struct *remove_work_wq;
 
 static struct ipmi_user *acquire_ipmi_user(struct ipmi_user *user, int *index)
        __acquires(user->release_barrier)