]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
ASoC: cs35l35: Add missing return in probe
authorCharles Keepax <ckeepax@opensource.wolfsonmicro.com>
Wed, 8 Mar 2017 16:42:47 +0000 (16:42 +0000)
committerMark Brown <broonie@kernel.org>
Mon, 13 Mar 2017 16:09:10 +0000 (16:09 +0000)
A return statement is missing just before the error paths at the end of
probe. This causes us to fall straight into the error path and disable
the supplies and re-enable reset, as these are only controlled during
probe this causes the part to no longer function.

Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Acked-by: Brian Austin <brian.austin@cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cs35l35.c

index 260ed42c71e9bed04cd53f136572ba817e367ebf..48b45dc904ea80dd03f405cd6ce09e68d3ddcab1 100644 (file)
@@ -1509,6 +1509,8 @@ static int cs35l35_i2c_probe(struct i2c_client *i2c_client,
                goto err;
        }
 
+       return 0;
+
 err:
        regulator_bulk_disable(cs35l35->num_supplies,
                               cs35l35->supplies);