]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
scsi: qla2xxx: Fix session lookup in qlt_abort_work()
authorBart Van Assche <bvanassche@acm.org>
Fri, 9 Aug 2019 03:01:40 +0000 (20:01 -0700)
committerMarcelo Henrique Cerri <marcelo.cerri@canonical.com>
Fri, 17 Jan 2020 17:22:49 +0000 (14:22 -0300)
BugLink: https://bugs.launchpad.net/bugs/1857158
[ Upstream commit ac452b8e79320c9e90c78edf32ba2d42431e4daf ]

Pass the correct session ID to find_sess_by_s_id() instead of passing an
uninitialized variable.

Cc: Himanshu Madhani <hmadhani@marvell.com>
Fixes: 2d70c103fd2a ("[SCSI] qla2xxx: Add LLD target-mode infrastructure for >= 24xx series") # v3.5.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Tested-by: Himanshu Madhani <hmadhani@marvell.com>
Reviewed-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/scsi/qla2xxx/qla_target.c

index 7c4e8cfbc97ba0cf3c4165405a16812072a2ef25..901c772fa3e2993776d9274546a8ab1f78ca7d89 100644 (file)
@@ -6022,7 +6022,6 @@ static void qlt_abort_work(struct qla_tgt *tgt,
        struct qla_hw_data *ha = vha->hw;
        struct fc_port *sess = NULL;
        unsigned long flags = 0, flags2 = 0;
-       uint32_t be_s_id;
        uint8_t s_id[3];
        int rc;
 
@@ -6035,8 +6034,7 @@ static void qlt_abort_work(struct qla_tgt *tgt,
        s_id[1] = prm->abts.fcp_hdr_le.s_id[1];
        s_id[2] = prm->abts.fcp_hdr_le.s_id[0];
 
-       sess = ha->tgt.tgt_ops->find_sess_by_s_id(vha,
-           (unsigned char *)&be_s_id);
+       sess = ha->tgt.tgt_ops->find_sess_by_s_id(vha, s_id);
        if (!sess) {
                spin_unlock_irqrestore(&ha->tgt.sess_lock, flags2);