]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
drm/amdgpu: Make umc_v8_10_convert_error_address static and remove unused variable
authorCandice Li <candice.li@amd.com>
Fri, 24 Feb 2023 04:15:57 +0000 (12:15 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 2 Mar 2023 03:37:55 +0000 (22:37 -0500)
Fixes following warnings:
warning: no previous prototype for 'umc_v8_10_convert_error_address'
warning: variable 'channel_index' set but not used

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Candice Li <candice.li@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/umc_v8_10.c

index 66158219f791cb722cfd86311b3426acfbc3609d..fb55e8cb9967ad9b2d2d6b6fb166fba9c211c26f 100644 (file)
@@ -209,10 +209,10 @@ static int umc_v8_10_swizzle_mode_na_to_pa(struct amdgpu_device *adev,
        return 0;
 }
 
-void umc_v8_10_convert_error_address(struct amdgpu_device *adev,
-                                   struct ras_err_data *err_data, uint64_t err_addr,
-                                   uint32_t ch_inst, uint32_t umc_inst,
-                                   uint32_t node_inst, uint64_t mc_umc_status)
+static void umc_v8_10_convert_error_address(struct amdgpu_device *adev,
+                                           struct ras_err_data *err_data, uint64_t err_addr,
+                                           uint32_t ch_inst, uint32_t umc_inst,
+                                           uint32_t node_inst, uint64_t mc_umc_status)
 {
        uint64_t na_err_addr_base;
        uint64_t na_err_addr, retired_page_addr;
@@ -434,7 +434,7 @@ static void umc_v8_10_ecc_info_query_error_address(struct amdgpu_device *adev,
                                        uint32_t umc_inst,
                                        uint32_t node_inst)
 {
-       uint32_t eccinfo_table_idx, channel_index;
+       uint32_t eccinfo_table_idx;
        uint64_t mc_umc_status, err_addr;
 
        struct amdgpu_ras *ras = amdgpu_ras_get_context(adev);
@@ -443,11 +443,6 @@ static void umc_v8_10_ecc_info_query_error_address(struct amdgpu_device *adev,
                                  adev->umc.channel_inst_num +
                                  umc_inst * adev->umc.channel_inst_num +
                                  ch_inst;
-       channel_index =
-               adev->umc.channel_idx_tbl[node_inst * adev->umc.umc_inst_num *
-                                                 adev->umc.channel_inst_num +
-                                                 umc_inst * adev->umc.channel_inst_num +
-                                                 ch_inst];
 
        mc_umc_status = ras->umc_ecc.ecc[eccinfo_table_idx].mca_umc_status;