]> git.proxmox.com Git - qemu.git/commitdiff
qemu-sockets: Fix parsing of the inet option 'to'.
authorAnthony PERARD <anthony.perard@citrix.com>
Fri, 16 Nov 2012 04:08:14 +0000 (04:08 +0000)
committermalc <av1474@comtv.ru>
Wed, 21 Nov 2012 08:07:59 +0000 (12:07 +0400)
Having a qemu command line argument like "-vnc 127.0.0.1:0,to=99" is broken.
This have been break with commit 879e45c72da1569e07fbbc6a1aa2a708ea796044.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: malc <av1474@comtv.ru>
qemu-sockets.c

index cfed9c5a5bd9e14b68015a1be2f909eabfa73cc6..d314cf1d1bad66e8299c9b6266b25d2a94ff01dc 100644 (file)
@@ -529,8 +529,9 @@ static InetSocketAddress *inet_parse(const char *str, Error **errp)
     optstr = str + pos;
     h = strstr(optstr, ",to=");
     if (h) {
-        if (1 != sscanf(str, "%d%n", &to, &pos) ||
-            (str[pos] != '\0' && str[pos] != ',')) {
+        h += 4;
+        if (sscanf(h, "%d%n", &to, &pos) != 1 ||
+            (h[pos] != '\0' && h[pos] != ',')) {
             error_setg(errp, "error parsing to= argument");
             goto fail;
         }