]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
staging: rtl8192e: make const array broadcast_addr static, reduces object code size
authorColin Ian King <colin.king@canonical.com>
Fri, 22 Sep 2017 15:20:18 +0000 (16:20 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 3 Oct 2017 16:34:57 +0000 (18:34 +0200)
Don't populate const array broadcast_addr on the stack, instead make it
static. Makes the object code smaller by over 40 bytes:

Before:
   text    data     bss     dec     hex filename
  63906    8248    1216   73370   11e9a rtllib_softmac.o

After:
   text    data     bss     dec     hex filename
  63806    8304    1216   73326   11e6e rtllib_softmac.o

(gcc 6.3.0, x86-64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtllib_softmac.c

index e4be85af31e7b6cec1407f63d65c7fbc73511982..1e308dfd7f74f1df574314d086b9212b9285f55d 100644 (file)
@@ -2811,8 +2811,9 @@ exit:
 
 static struct sk_buff *rtllib_get_beacon_(struct rtllib_device *ieee)
 {
-       const u8 broadcast_addr[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
-
+       static const u8 broadcast_addr[] = {
+               0xff, 0xff, 0xff, 0xff, 0xff, 0xff
+       };
        struct sk_buff *skb;
        struct rtllib_probe_response *b;