]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
sound: soc: codecs: mt6358: change return type of mt6358_codec_init_reg
authorHariprasad Kelam <hariprasad.kelam@gmail.com>
Tue, 9 Jul 2019 18:25:43 +0000 (23:55 +0530)
committerMark Brown <broonie@kernel.org>
Mon, 22 Jul 2019 12:10:57 +0000 (13:10 +0100)
As mt6358_codec_init_reg function always returns 0 , change return type
from int to void.

fixes below issue reported by coccicheck
sound/soc/codecs/mt6358.c:2260:5-8: Unneeded variable: "ret". Return "0"
on line 2289

Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Acked-by: Tzung-Bi Shih <tzungbi@google.com>
Link: https://lore.kernel.org/r/20190709182543.GA6611@hari-Inspiron-1545
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/mt6358.c

index 50b3fc5457ea717a390879a7ac7edc9268128522..c17250aab2d0bbc13008f899befec620b0dc422b 100644 (file)
@@ -2255,10 +2255,8 @@ static struct snd_soc_dai_driver mt6358_dai_driver[] = {
        },
 };
 
-static int mt6358_codec_init_reg(struct mt6358_priv *priv)
+static void mt6358_codec_init_reg(struct mt6358_priv *priv)
 {
-       int ret = 0;
-
        /* Disable HeadphoneL/HeadphoneR short circuit protection */
        regmap_update_bits(priv->regmap, MT6358_AUDDEC_ANA_CON0,
                           RG_AUDHPLSCDISABLE_VAUDP15_MASK_SFT,
@@ -2285,8 +2283,6 @@ static int mt6358_codec_init_reg(struct mt6358_priv *priv)
        /* set gpio */
        playback_gpio_reset(priv);
        capture_gpio_reset(priv);
-
-       return ret;
 }
 
 static int mt6358_codec_probe(struct snd_soc_component *cmpnt)