]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
net: aquantia: fix return value check in aq_ptp_init()
authorWei Yongjun <weiyongjun1@huawei.com>
Wed, 6 Nov 2019 14:59:21 +0000 (14:59 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 7 Nov 2019 05:21:09 +0000 (21:21 -0800)
Function ptp_clock_register() returns ERR_PTR() and never returns
NULL. The NULL test should be removed.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Igor Russkikh <irusskikh@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/aquantia/atlantic/aq_ptp.c

index 8175513e48c9c342f00960603462cf7bd4b86704..1f9eab74453e7a5eeadb138a1b640e45d2876134 100644 (file)
@@ -1207,7 +1207,7 @@ int aq_ptp_init(struct aq_nic_s *aq_nic, unsigned int idx_vec)
        aq_ptp->ptp_info = aq_ptp_clock;
        aq_ptp_gpio_init(&aq_ptp->ptp_info, &mbox.info);
        clock = ptp_clock_register(&aq_ptp->ptp_info, &aq_nic->ndev->dev);
-       if (!clock || IS_ERR(clock)) {
+       if (IS_ERR(clock)) {
                netdev_err(aq_nic->ndev, "ptp_clock_register failed\n");
                err = PTR_ERR(clock);
                goto err_exit;