]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
MIPS/tlbex: Fix LDDIR usage in setup_pw() for Loongson-3
authorHuacai Chen <chenhc@lemote.com>
Wed, 25 Mar 2020 03:44:54 +0000 (11:44 +0800)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 29 Apr 2020 12:56:05 +0000 (14:56 +0200)
BugLink: https://bugs.launchpad.net/bugs/1874502
commit d191aaffe3687d1e73e644c185f5f0550ec242b5 upstream.

LDDIR/LDPTE is Loongson-3's acceleration for Page Table Walking. If BD
(Base Directory, the 4th page directory) is not enabled, then GDOffset
is biased by BadVAddr[63:62]. So, if GDOffset (aka. BadVAddr[47:36] for
Loongson-3) is big enough, "0b11(BadVAddr[63:62])|BadVAddr[47:36]|...."
can far beyond pg_swapper_dir. This means the pg_swapper_dir may NOT be
accessed by LDDIR correctly, so fix it by set PWDirExt in CP0_PWCtl.

Cc: <stable@vger.kernel.org>
Signed-off-by: Pei Huang <huangpei@loongson.cn>
Signed-off-by: Huacai Chen <chenhc@lemote.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
arch/mips/mm/tlbex.c

index b55c74a7f7a4caccbf3d4f528236e26fe2d4bb72..47a7492a1af4de8bd91ec1a074c46278209affac 100644 (file)
@@ -1484,6 +1484,7 @@ static void build_r4000_tlb_refill_handler(void)
 
 static void setup_pw(void)
 {
+       unsigned int pwctl;
        unsigned long pgd_i, pgd_w;
 #ifndef __PAGETABLE_PMD_FOLDED
        unsigned long pmd_i, pmd_w;
@@ -1510,6 +1511,7 @@ static void setup_pw(void)
 
        pte_i = ilog2(_PAGE_GLOBAL);
        pte_w = 0;
+       pwctl = 1 << 30; /* Set PWDirExt */
 
 #ifndef __PAGETABLE_PMD_FOLDED
        write_c0_pwfield(pgd_i << 24 | pmd_i << 12 | pt_i << 6 | pte_i);
@@ -1520,8 +1522,9 @@ static void setup_pw(void)
 #endif
 
 #ifdef CONFIG_MIPS_HUGE_TLB_SUPPORT
-       write_c0_pwctl(1 << 6 | psn);
+       pwctl |= (1 << 6 | psn);
 #endif
+       write_c0_pwctl(pwctl);
        write_c0_kpgd(swapper_pg_dir);
        kscratch_used_mask |= (1 << 7); /* KScratch6 is used for KPGD */
 }