]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
media: ov7670: Check the return value from clk_prepare_enable()
authorFabio Estevam <fabio.estevam@nxp.com>
Wed, 19 Jul 2017 03:34:19 +0000 (23:34 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 8 Aug 2017 10:24:58 +0000 (06:24 -0400)
clk_prepare_enable() may fail, so we should better check its return value
and propagate it in the case of error.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/i2c/ov7670.c

index 552a881e24da246b6f0842f19292e53404e16157..e88549f0e70465dd78c5f78f1f2c62d8e5b296f7 100644 (file)
@@ -1615,7 +1615,9 @@ static int ov7670_probe(struct i2c_client *client,
        info->clk = devm_clk_get(&client->dev, "xclk");
        if (IS_ERR(info->clk))
                return PTR_ERR(info->clk);
-       clk_prepare_enable(info->clk);
+       ret = clk_prepare_enable(info->clk);
+       if (ret)
+               return ret;
 
        ret = ov7670_init_gpio(client, info);
        if (ret)