]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
Bluetooth: hci_bcm: Move bcm_platform_probe call out of bcm_acpi_probe
authorHans de Goede <hdegoede@redhat.com>
Wed, 4 Oct 2017 18:43:37 +0000 (20:43 +0200)
committerMarcel Holtmann <marcel@holtmann.org>
Fri, 6 Oct 2017 18:35:48 +0000 (20:35 +0200)
Since bcm_acpi_probe calls bcm_platform_probe, bcm_probe always ends up
calling bcm_platform_probe.

This commit simplifies things by making bcm_probe always call
bcm_platform_probe itself.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/bluetooth/hci_bcm.c

index 73d2d88ddc03987cf4275d51b2fb1a952a924d15..1a9ce68b9a9b1c33bca673aecff09a155042d228 100644 (file)
@@ -820,10 +820,6 @@ static int bcm_acpi_probe(struct bcm_device *dev)
        if (ret)
                return ret;
 
-       ret = bcm_platform_probe(dev);
-       if (ret)
-               return ret;
-
        /* Retrieve UART ACPI info */
        ret = acpi_dev_get_resources(ACPI_COMPANION(&dev->pdev->dev),
                                     &resources, bcm_resource, dev);
@@ -858,10 +854,13 @@ static int bcm_probe(struct platform_device *pdev)
 
        dev->pdev = pdev;
 
-       if (has_acpi_companion(&pdev->dev))
+       if (has_acpi_companion(&pdev->dev)) {
                ret = bcm_acpi_probe(dev);
-       else
-               ret = bcm_platform_probe(dev);
+               if (ret)
+                       return ret;
+       }
+
+       ret = bcm_platform_probe(dev);
        if (ret)
                return ret;