]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
pinctrl: qcom: spmi-gpio: Reorder debug print
authorBjorn Andersson <bjorn.andersson@linaro.org>
Tue, 19 Feb 2019 19:12:53 +0000 (11:12 -0800)
committerLinus Walleij <linus.walleij@linaro.org>
Thu, 21 Feb 2019 12:15:07 +0000 (13:15 +0100)
It's reasonable to expect that people turn to the "gpio" debugfs file to
first and foremost learn about the direction and value of a gpio, and
second to that about it's pinconf. So reorder the value so each line
reads:

gpioN: direction value ...

This also makes it consistent with the TLMM pinctrl driver's output in
the same dump.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c

index e01a556ac586cd1b83fbe1f887063db48fbab394..df7d6f4ccf5d6bbc995797278bd3e028e524ac7f 100644 (file)
@@ -675,11 +675,11 @@ static void pmic_gpio_config_dbg_show(struct pinctrl_dev *pctldev,
                else
                        seq_printf(s, " %-4s",
                                        pad->output_enabled ? "out" : "in");
+               seq_printf(s, " %-4s", pad->out_value ? "high" : "low");
                seq_printf(s, " %-7s", pmic_gpio_functions[function]);
                seq_printf(s, " vin-%d", pad->power_source);
                seq_printf(s, " %-27s", biases[pad->pullup]);
                seq_printf(s, " %-10s", buffer_types[pad->buffer_type]);
-               seq_printf(s, " %-4s", pad->out_value ? "high" : "low");
                seq_printf(s, " %-7s", strengths[pad->strength]);
                seq_printf(s, " atest-%d", pad->atest);
                seq_printf(s, " dtest-%d", pad->dtest_buffer);