Fix upperiface check when ifdown is run with -a

Ticket: CM-3007
Reviewed By: shm + patch was pasted in the bug for review
Testing Done: ran precommit + maliks test + malik ran his test on his
box

When -a is specified ifupdown2 works on all interfaces and since the the
upperiface check is a bit expensive i had a "skip" on that.
And so far all the user commands i have seen only work on the $IFACE and
not its dependents. So, never hit this case.

diff --git a/pkg/scheduler.py b/pkg/scheduler.py
index 17c7d761d65ee9a2a6dbfce268e9d52dde0f7d65..6fc19c5bf96a9941033aa48f1940da1495dd159c 100644 (file)
--- a/pkg/scheduler.py
+++ b/pkg/scheduler.py
@@ -150,12 +150,14 @@ class ifaceScheduler():
         if (ifupdownobj.FORCE or
                 not ifupdownobj.ADDONS_ENABLE or
                 (not ifupdownobj.is_ifaceobj_noconfig(ifaceobj) and
-                ifupdownobj.config.get('warn_on_ifdown', '0') == '0')):
+                ifupdownobj.config.get('warn_on_ifdown', '0') == '0' and
+                not ifupdownobj.ALL)):
             return True
 
         ulist = ifaceobj.upperifaces
         if not ulist:
             return True
+
         # Get the list of upper ifaces other than the parent
         tmpulist = ([u for u in ulist if u != parent] if parent
                     else ulist)