]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
net: phy: consider PHY_IGNORE_INTERRUPT in phy_start_aneg_priv
authorHeiner Kallweit <hkallweit1@gmail.com>
Thu, 19 Jul 2018 06:15:16 +0000 (08:15 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sat, 21 Jul 2018 23:20:38 +0000 (16:20 -0700)
The situation described in the comment can occur also with
PHY_IGNORE_INTERRUPT, therefore change the condition to include it.

Fixes: f555f34fdc58 ("net: phy: fix auto-negotiation stall due to unavailable interrupt")
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phy.c

index 537297d2b4b4309adeacd1e66541b2aa1830b8b8..6c9b24fe31488b03499a9866f13a065449b29cce 100644 (file)
@@ -514,7 +514,7 @@ static int phy_start_aneg_priv(struct phy_device *phydev, bool sync)
         * negotiation may already be done and aneg interrupt may not be
         * generated.
         */
-       if (phy_interrupt_is_valid(phydev) && (phydev->state == PHY_AN)) {
+       if (phydev->irq != PHY_POLL && phydev->state == PHY_AN) {
                err = phy_aneg_done(phydev);
                if (err > 0) {
                        trigger = true;