]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commitdiff
staging: usbip: removed unnecessary if-else-statements
authorKurt Kanzenbach <ly80toro@cip.cs.fau.de>
Thu, 4 Apr 2013 14:03:09 +0000 (16:03 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 5 Apr 2013 21:22:51 +0000 (14:22 -0700)
In each if-else case "return" is called. This is why
these if-else-statements are useless. Removing them
improves understanding and readability.

Signed-off-by: Kurt Kanzenbach <ly80toro@cip.cs.fau.de>
Signed-off-by: Stefan Reif <ke42caxa@cip.cs.fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/usbip/stub_main.c

index 705a9e530a19c378fd16d3db39033bfea7342dce..629bfcbcb9b0788bf5c1df2fd37d138e5faa6e4a 100644 (file)
@@ -167,22 +167,22 @@ static ssize_t store_match_busid(struct device_driver *dev, const char *buf,
        strncpy(busid, buf + 4, BUSID_SIZE);
 
        if (!strncmp(buf, "add ", 4)) {
-               if (add_match_busid(busid) < 0) {
+               if (add_match_busid(busid) < 0)
                        return -ENOMEM;
-               } else {
-                       pr_debug("add busid %s\n", busid);
-                       return count;
-               }
-       } else if (!strncmp(buf, "del ", 4)) {
-               if (del_match_busid(busid) < 0) {
+
+               pr_debug("add busid %s\n", busid);
+               return count;
+       }
+
+       if (!strncmp(buf, "del ", 4)) {
+               if (del_match_busid(busid) < 0)
                        return -ENODEV;
-               } else {
-                       pr_debug("del busid %s\n", busid);
-                       return count;
-               }
-       } else {
-               return -EINVAL;
+
+               pr_debug("del busid %s\n", busid);
+               return count;
        }
+
+       return -EINVAL;
 }
 static DRIVER_ATTR(match_busid, S_IRUSR | S_IWUSR, show_match_busid,
                   store_match_busid);