f2fs: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Cc: linux-f2fs-devel@lists.sourceforge.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c
index ebcc121920bac719c25174c62185dc761faff8bc..fd7f170e2f2d6ac93b20b80b9c8e5a898b674dcf 100644 (file)
--- a/fs/f2fs/debug.c
+++ b/fs/f2fs/debug.c
@@ -506,30 +506,16 @@ void f2fs_destroy_stats(struct f2fs_sb_info *sbi)
        kvfree(si);
 }
 
-int __init f2fs_create_root_stats(void)
+void __init f2fs_create_root_stats(void)
 {
-       struct dentry *file;
-
        f2fs_debugfs_root = debugfs_create_dir("f2fs", NULL);
-       if (!f2fs_debugfs_root)
-               return -ENOMEM;
 
-       file = debugfs_create_file("status", S_IRUGO, f2fs_debugfs_root,
-                       NULL, &stat_fops);
-       if (!file) {
-               debugfs_remove(f2fs_debugfs_root);
-               f2fs_debugfs_root = NULL;
-               return -ENOMEM;
-       }
-
-       return 0;
+       debugfs_create_file("status", S_IRUGO, f2fs_debugfs_root, NULL,
+                           &stat_fops);
 }
 
 void f2fs_destroy_root_stats(void)
 {
-       if (!f2fs_debugfs_root)
-               return;
-
        debugfs_remove_recursive(f2fs_debugfs_root);
        f2fs_debugfs_root = NULL;
 }

diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 12fabd6735ddb88e3eab3460b8a912924d164636..8f23ee6e8eb99860dc89f6a9d72b3e1948e9ba3e 100644 (file)
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -3328,7 +3328,7 @@ static inline struct f2fs_stat_info *F2FS_STAT(struct f2fs_sb_info *sbi)
 
 int f2fs_build_stats(struct f2fs_sb_info *sbi);
 void f2fs_destroy_stats(struct f2fs_sb_info *sbi);
-int __init f2fs_create_root_stats(void);
+void __init f2fs_create_root_stats(void);
 void f2fs_destroy_root_stats(void);
 #else
 #define stat_inc_cp_count(si)                          do { } while (0)
@@ -3366,7 +3366,7 @@ void f2fs_destroy_root_stats(void);
 
 static inline int f2fs_build_stats(struct f2fs_sb_info *sbi) { return 0; }
 static inline void f2fs_destroy_stats(struct f2fs_sb_info *sbi) { }
-static inline int __init f2fs_create_root_stats(void) { return 0; }
+static inline void __init f2fs_create_root_stats(void) { }
 static inline void f2fs_destroy_root_stats(void) { }
 #endif
 

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index c46a1d4318d419181713a44c11b917282352804b..3d3ce9eb6d13ce7276ddf8cc428117bfe4f18d06 100644 (file)
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -3545,9 +3545,7 @@ static int __init init_f2fs_fs(void)
        err = register_filesystem(&f2fs_fs_type);
        if (err)
                goto free_shrinker;
-       err = f2fs_create_root_stats();
-       if (err)
-               goto free_filesystem;
+       f2fs_create_root_stats();
        err = f2fs_init_post_read_processing();
        if (err)
                goto free_root_stats;
@@ -3555,7 +3553,6 @@ static int __init init_f2fs_fs(void)
 
 free_root_stats:
        f2fs_destroy_root_stats();
-free_filesystem:
        unregister_filesystem(&f2fs_fs_type);
 free_shrinker:
        unregister_shrinker(&f2fs_shrinker_info);