]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
irqchip/gic-v3: Use wmb() instead of smb_wmb() in gic_raise_softirq()
authorShanker Donthineni <shankerd@codeaurora.org>
Thu, 1 Feb 2018 00:03:42 +0000 (18:03 -0600)
committerMarc Zyngier <marc.zyngier@arm.com>
Fri, 16 Feb 2018 13:47:58 +0000 (13:47 +0000)
A DMB instruction can be used to ensure the relative order of only
memory accesses before and after the barrier. Since writes to system
registers are not memory operations, barrier DMB is not sufficient
for observability of memory accesses that occur before ICC_SGI1R_EL1
writes.

A DSB instruction ensures that no instructions that appear in program
order after the DSB instruction, can execute until the DSB instruction
has completed.

Cc: stable@vger.kernel.org
Acked-by: Will Deacon <will.deacon@arm.com>,
Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
drivers/irqchip/irq-gic-v3.c

index d71be9a1f9d286db047083c931a54816533ab12c..d99cc07903ec497279e3baf563743d9146e77f09 100644 (file)
@@ -688,7 +688,7 @@ static void gic_raise_softirq(const struct cpumask *mask, unsigned int irq)
         * Ensure that stores to Normal memory are visible to the
         * other CPUs before issuing the IPI.
         */
-       smp_wmb();
+       wmb();
 
        for_each_cpu(cpu, mask) {
                u64 cluster_id = MPIDR_TO_SGI_CLUSTER_ID(cpu_logical_map(cpu));