]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
drm/i915/icl: NV12 y-plane ddb is not in same plane
authorMahesh Kumar <mahesh1.kumar@intel.com>
Tue, 30 Jan 2018 13:49:13 +0000 (11:49 -0200)
committerPaulo Zanoni <paulo.r.zanoni@intel.com>
Wed, 31 Jan 2018 16:19:51 +0000 (14:19 -0200)
We don't have planar pixel format support implemented for ICL yet.
ICL require 2 display planes to be allocated for Planar formats unlike
previous GEN. So ICL/GEN11 doesn't require to write Y-plane ddb data in
NV12_BUF_CFG register and PLANE_NV12_BUF_CFG register is removed in ICL.

This patch removes the PLANE_NV12_BUF_CFG write for ICL.

Changes Since V1:
 - Improve commit message as per Paulo's comment

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: James Ausmus <james.ausmus@intel.com>
Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180130134918.32283-5-paulo.r.zanoni@intel.com
drivers/gpu/drm/i915/intel_pm.c

index 24421603e605b528e31f538d4fb1276d7bf9957a..766f4fdd633b8c1efecd6f2ec3d561171117203a 100644 (file)
@@ -4826,8 +4826,10 @@ static void skl_write_plane_wm(struct intel_crtc *intel_crtc,
 
        skl_ddb_entry_write(dev_priv, PLANE_BUF_CFG(pipe, plane_id),
                            &ddb->plane[pipe][plane_id]);
-       skl_ddb_entry_write(dev_priv, PLANE_NV12_BUF_CFG(pipe, plane_id),
-                           &ddb->y_plane[pipe][plane_id]);
+       if (INTEL_GEN(dev_priv) < 11)
+               skl_ddb_entry_write(dev_priv,
+                                   PLANE_NV12_BUF_CFG(pipe, plane_id),
+                                   &ddb->y_plane[pipe][plane_id]);
 }
 
 static void skl_write_cursor_wm(struct intel_crtc *intel_crtc,